Repository navigation
test(sql-workspace): run the selection through the mounted editor (#1148) - #1205
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1148
What was wrong
The test "only the selected text runs when there is a selection" was disabled. Setting the controller value directly hung CI for the whole timeout, and it does not match how a user makes a selection. Without it, the selection path of Ctrl+Enter / the run statement had no test.
Changes
EditableText(userUpdateTextEditingValue), as the comment on the skip suggested.Not verified locally
Tests were not run locally, per the project rule. The test runs in CI, which will show whether the hang is gone; the 60 s timeout still applies.